[ https://issues.apache.org/jira/browse/ZOOKEEPER-1807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13972120#comment-13972120 ]
Hadoop QA commented on ZOOKEEPER-1807: -------------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12640553/ZOOKEEPER-1807-ver5.patch against trunk revision 1587818. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2046//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2046//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2046//console This message is automatically generated. > Observers spam each other creating connections to the election addr > ------------------------------------------------------------------- > > Key: ZOOKEEPER-1807 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1807 > Project: ZooKeeper > Issue Type: Bug > Reporter: Raul Gutierrez Segales > Assignee: Alexander Shraer > Priority: Blocker > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1807-alex.patch, ZOOKEEPER-1807-ver2.patch, > ZOOKEEPER-1807-ver3.patch, ZOOKEEPER-1807-ver4.patch, > ZOOKEEPER-1807-ver5.patch, ZOOKEEPER-1807.patch, notifications-loop.png > > > Hey [~shralex], > I noticed today that my Observers are spamming each other trying to open > connections to the election port. I've got tons of these: > {noformat} > 2013-11-01 22:19:45,819 - DEBUG [WorkerSender[myid=13]] - There is a > connection already for server 9 > 2013-11-01 22:19:45,819 - DEBUG [WorkerSender[myid=13]] - There is a > connection already for server 10 > 2013-11-01 22:19:45,819 - DEBUG [WorkerSender[myid=13]] - There is a > connection already for server 6 > 2013-11-01 22:19:45,819 - DEBUG [WorkerSender[myid=13]] - There is a > connection already for server 12 > 2013-11-01 22:19:45,819 - DEBUG [WorkerSender[myid=13]] - There is a > connection already for server 14 > {noformat} > and so and so on ad nauseam. > Now, looking around I found this inside FastLeaderElection.java from when you > committed ZOOKEEPER-107: > {noformat} > private void sendNotifications() { > - for (QuorumServer server : self.getVotingView().values()) { > - long sid = server.id; > - > + for (long sid : self.getAllKnownServerIds()) { > + QuorumVerifier qv = self.getQuorumVerifier(); > {noformat} > Is that really desired? I suspect that is what's causing Observers to try to > connect to each other (as opposed as just connecting to participants). I'll > give it a try now and let you know. (Also, we use observer ids that are > 0, > and I saw some parts of the code that might not deal with that assumption - > so it could be that too..). -- This message was sent by Atlassian JIRA (v6.2#6252)