[
https://issues.apache.org/jira/browse/ZOOKEEPER-1695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13980942#comment-13980942
]
Hadoop QA commented on ZOOKEEPER-1695:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12641901/ZOOKEEPER-1695.patch
against trunk revision 1589949.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2065//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2065//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2065//console
This message is automatically generated.
> Inconsistent error code and type for new errors introduced by dynamic
> reconfiguration
> ---------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1695
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1695
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.5.0
> Reporter: Thawan Kooburat
> Assignee: Michi Mutsuzaki
> Priority: Blocker
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1695.patch, ZOOKEEPER-1695.patch,
> ZOOKEEPER-1695.patch, ZOOKEEPER-1695.patch
>
>
> From KeeperException.Code, RECONFIGINPROGRESS and NEWCONFIGNOQUORUM are
> declared as system errors. However, their error code suggested that they are
> API errors.
> We either need to move it to the right type or use the code from the right
> range
--
This message was sent by Atlassian JIRA
(v6.2#6252)
