-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19794/
-----------------------------------------------------------
(Updated May 2, 2014, 3:07 p.m.)
Review request for zookeeper, fpj, michim, Raul Gutierrez Segales, and Camille
Fournier.
Changes
-------
Addressing Bill's comment. Updated new patch by including few more unit tests
which contains the following changes:
1) created new method visible for testing PurgeTxnLog#retainNRecentSnapshots()
2) Added 4 new test cases.
3) PurgeTxnTest class moved to 'org.apache.zookeeper.server' package
Bugs: ZOOKEEPER-1797
https://issues.apache.org/jira/browse/ZOOKEEPER-1797
Repository: zookeeper
Description
-------
PurgeTxnLog may delete data logs if logs are rolling or a new snapshot is
created during this process
Diffs (updated)
-----
./src/java/main/org/apache/zookeeper/server/PurgeTxnLog.java 1591929
./src/java/test/org/apache/zookeeper/server/PurgeTxnTest.java PRE-CREATION
./src/java/test/org/apache/zookeeper/test/PurgeTxnTest.java 1591929
Diff: https://reviews.apache.org/r/19794/diff/
Testing
-------
I've tried to add a tests
Thanks,
Rakesh R
