[
https://issues.apache.org/jira/browse/ZOOKEEPER-770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13999566#comment-13999566
]
Hadoop QA commented on ZOOKEEPER-770:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12645128/ZOOKEEPER-770.patch
against trunk revision 1595038.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2097//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2097//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2097//console
This message is automatically generated.
> Slow add_auth calls with multi-threaded client
> ----------------------------------------------
>
> Key: ZOOKEEPER-770
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-770
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client, contrib-bindings
> Affects Versions: 3.3.0, 3.3.3, 3.4.0
> Environment: ubuntu lucid (10.04), zk trunk (3.4)
> Reporter: Kapil Thangavelu
> Assignee: Craig Calef
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-770-FIX.patch, ZOOKEEPER-770.patch,
> ZOOKEEPER-770.patch, authtest.py
>
>
> Calls to add_auth are a bit slow from the c client library. The auth callback
> typically takes multiple seconds to fire. I instrumented the java, c binding,
> and python binding with a few log statements to find out where the slowness
> was occuring (
> http://bazaar.launchpad.net/~hazmat/zookeeper/fast-auth-instrumented/revision/647).
> It looks like when the io thread polls, it doesn't register interest in the
> incoming packet, so the auth success message from the server and the auth
> callback are only processed when the poll timeouts. I tried modifying
> mt_adapter.c so the poll registers interest in both events, this causes a
> considerably more wakeups but it does address the issue of making add_auth
> fast. I think the ideal solution would be some sort of additional auth
> handshake state on the handle, that zookeeper_interest could utilize to
> suggest both POLLIN|POLLOUT are wanted for subsequent calls to poll during
> the auth handshake handle state.
> i'm attaching a script that takes 13s or 1.6s for the auth callback depending
> on the session time out value (which in turn figures into the calculation of
> the poll timeout).
--
This message was sent by Atlassian JIRA
(v6.2#6252)
