[
https://issues.apache.org/jira/browse/ZOOKEEPER-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14030756#comment-14030756
]
ASF GitHub Bot commented on ZOOKEEPER-1350:
-------------------------------------------
GitHub user sslavic opened a pull request:
https://github.com/apache/zookeeper/pull/14
Make JMX registration optional
This patch is a modification of patch.txt, which is attached to
ZOOKEEPER-1350, that can be applied to "trunk" branch.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sslavic/zookeeper ZOOKEEPER-1350-trunk
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/14.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #14
----
commit d24041b6443a3979134917e44fcb5a8e29b47f42
Author: Stevo Slavic <[email protected]>
Date: 2014-06-13T15:36:02Z
ZOOKEEPER-1350 Made JMX registration optional
----
> Please make JMX registration optional in LearnerZooKeeperServer
> ---------------------------------------------------------------
>
> Key: ZOOKEEPER-1350
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1350
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.4.0
> Reporter: Jordan Zimmerman
> Assignee: Jordan Zimmerman
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1350.diff, jmx_optional.diff, patch.txt
>
>
> LearnerZooKeeperServer has no option to disable JMX registrations. Curator
> has a test ZK server cluster. Due to the intricacies of JMX, the
> registrations cannot be easily undone. In order for the Curator Test cluster
> to be re-usable in a testing session, JavaAssist ugliness was necessary to
> make LearnerZooKeeperServer.registerJMX() and
> LearnerZooKeeperServer.unregisterJMX() NOPs.
> I suggest a simple System property.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
