[
https://issues.apache.org/jira/browse/ZOOKEEPER-1946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14043974#comment-14043974
]
Alexander Shraer commented on ZOOKEEPER-1946:
---------------------------------------------
Hi Nikko,
The patch looks good, thanks! my only suggestion is to modify testPortChange()
in src/java/test/org/apache/zookeeper/test/ReconfigTest.java to check for the
thread id before and after the reconfig.
Thanks,
Alex
> Server logging should reflect dynamically reconfigured address
> --------------------------------------------------------------
>
> Key: ZOOKEEPER-1946
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1946
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.5.0
> Reporter: Niko Vuokko
> Assignee: Niko Vuokko
> Priority: Minor
> Labels: patch
> Attachments: ZOOKEEPER-1946.patch, ZOOKEEPER-1946.patch
>
>
> The server's client address:port is part of the QuorumPeer's thread name and
> thus shown in logs. Thread name is not currently updated after dynamic
> reconfiguration of the address, resulting in confusing log entries.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
