[ https://issues.apache.org/jira/browse/ZOOKEEPER-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14055133#comment-14055133 ]
Hadoop QA commented on ZOOKEEPER-1677: -------------------------------------- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12646152/ZOOKEEPER-1677.patch against trunk revision 1608648. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 7 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2179//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2179//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2179//console This message is automatically generated. > Misuse of INET_ADDRSTRLEN > ------------------------- > > Key: ZOOKEEPER-1677 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1677 > Project: ZooKeeper > Issue Type: Bug > Affects Versions: 3.5.0 > Reporter: Shevek > Assignee: Marshall McMullen > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1677.patch, ZOOKEEPER-1677.patch, > ZOOKEEPER-1677.patch, ZOOKEEPER-1677.patch, ZOOKEEPER-1677.patch, > ZOOKEEPER-1677.patch, ZOOKEEPER-1677.patch, ZOOKEEPER-1677.patch, > ZOOKEEPER-1677.patch > > > ZOOKEEPER-1355. Add zk.updateServerList(newServerList) (Alex Shraer, > Marshall McMullen via fpj) > > > > git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1410731 > 13f79535-47bb-0310-9956-ffa450edef68 > +int addrvec_contains(const addrvec_t *avec, const struct sockaddr_storage > *addr) > +{ > + if (!avec || !addr) > + { > + return 0; > + } > + > + int i = 0; > + for (i = 0; i < avec->count; i++) > + { > + if(memcmp(&avec->data[i], addr, INET_ADDRSTRLEN) == 0) > + return 1; > + } > + > + return 0; > +} > Pretty sure that should be sizeof(sockaddr_storage). INET_ADDRSTRLEN is the > size of the character buffer which needs to be allocated for the return value > of inet_ntop, which seems to be totally wrong. -- This message was sent by Atlassian JIRA (v6.2#6252)