[
https://issues.apache.org/jira/browse/ZOOKEEPER-1978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14070479#comment-14070479
]
Patrick Hunt commented on ZOOKEEPER-1978:
-----------------------------------------
Hi [~rakeshr], yes, your idea makes sense to me. [~hdeng] what do you think?
> Fix Multithreaded correctness Warnings
> --------------------------------------
>
> Key: ZOOKEEPER-1978
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1978
> Project: ZooKeeper
> Issue Type: Sub-task
> Reporter: Hongchao Deng
> Assignee: Hongchao Deng
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1978.patch
>
>
> findbugs is complaining
> {code}
> if (sessionsById.get(id) == null) {
> SessionImpl s = new SessionImpl(id, sessionTimeout);
> sessionsById.put(id, s);
> }
> {code}
> is not atomic for the gap between get() and put().
> I suggest using putIfAbsent() instead.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
