[ https://issues.apache.org/jira/browse/ZOOKEEPER-1985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14073033#comment-14073033 ]
Hadoop QA commented on ZOOKEEPER-1985: -------------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12657580/ZOOKEEPER-1985.patch against trunk revision 1612906. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2227//console This message is automatically generated. > Memory leak in C client > ----------------------- > > Key: ZOOKEEPER-1985 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1985 > Project: ZooKeeper > Issue Type: Bug > Components: c client > Affects Versions: 3.4.6 > Reporter: desmondhe > Assignee: desmondhe > Priority: Minor > Attachments: ZOOKEEPER-1985.patch > > > in the file zookeeper.c, most function call of "close_buffer_oarchive(&oa, > 0)" shoud been instead by > close_buffer_oarchive(&oa, rc < 0 ? 1 : 0); -- This message was sent by Atlassian JIRA (v6.2#6252)