[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14073561#comment-14073561
 ] 

Raul Gutierrez Segales commented on ZOOKEEPER-1988:
---------------------------------------------------

+1, I think it looks great. Thanks [~shralex]. One last nit though (feel free 
to leave it): since :

{noformat}
PathUtils.normalizeFileSystemPath
{noformat}

is already a static method inside PathUtils, you might as well just call it 
normalize (it is implicit it refers to paths):

{noformat}
PathUtils.normalize
{noformat}

Thanks for the quick updates. 

> new test patch
> --------------
>
>                 Key: ZOOKEEPER-1988
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1988
>             Project: ZooKeeper
>          Issue Type: Sub-task
>          Components: tests
>            Reporter: Raul Gutierrez Segales
>            Assignee: Alexander Shraer
>             Fix For: 3.5.0
>
>         Attachments: ZOOKEEPER-1987-ver4.patch, ZOOKEEPER-1987-ver5.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to