[
https://issues.apache.org/jira/browse/ZOOKEEPER-1933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14073875#comment-14073875
]
Raul Gutierrez Segales commented on ZOOKEEPER-1933:
---------------------------------------------------
lgtm, +1. some nits though, take them or leave them:
{noformat}
+ rc = select(/* unused */0, &rfds, &wfds, NULL, &tv);
+ if (rc > 0)
+ {
{noformat}
I think
{noformat}
if (rc > 0) {
{noformat}
is more consistent with the rest of the file (i.e.: the prev if block, etc.).
{noformat}
+ interest=(FD_ISSET(fd, &rfds))?ZOOKEEPER_READ:0;
+ interest|=(FD_ISSET(fd, &wfds))?ZOOKEEPER_WRITE:0;
+
{noformat}
spaces around =, |=, ? and : please.
{noformat}
+ if (FD_ISSET(adaptor_threads->self_pipe[0], &rfds)){
{noformat}
space between ) and { please.
{noformat}
+ else if (rc < 0)
+ {
{noformat}
should be
{noformat}
else if (rc < 0) {
{noformat}
for code style consistency.
And finally:
{noformat}
+
+ void testBadDescriptor() {
+ int zrc = 0;
+ watchctx_t *ctx;
+ zhandle_t *zh = zookeeper_init(hostPorts, NULL, 10000, 0, ctx, 0);
+ sleep(1);
+ zh->io_count = 0;
+ //close socket
+ close(zh->fd);
+ sleep(1);
+ //Check that doIo isn't spinning
+ CPPUNIT_ASSERT(zh->io_count < 2);
+ zookeeper_close(zh);
+ }
{noformat}
has weird indentation - mixing tabs and spaces perhaps?
> Windows release build of zk client cannot connect to zk server
> --------------------------------------------------------------
>
> Key: ZOOKEEPER-1933
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1933
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.4.6
> Reporter: Norris Lee
> Assignee: Orion Hodson
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1933-2.patch, ZOOKEEPER-1933-3.patch,
> ZOOKEEPER-1933.patch, ZOOKEEPER-1933.patch, ZOOKEEPER-1933.patch,
> ZOOKEEPER-1933.patch
>
>
> When building zookeeper in Visual Studio in debug mode, the client can
> connect to the server without error. When building in release mode, I get a
> continuous error message:
> {code}
> 2014-06-02 11:25:20,070:7144(0xc84):ZOO_INFO@zookeeper_init_internal@1008:
> Initiating client connection, host=192.168.39.43:5181 sessionTimeout=30000
> watcher=10049C90 sessionId=0 sessionPasswd=<null> context=001FC0F0 flags=0
> 2014-06-02 11:25:20,072:7144(0xc84):ZOO_DEBUG@start_threads@221: starting
> threads...
> 2014-06-02 11:25:20,072:7144(0x1ea0):ZOO_DEBUG@do_completion@460: started
> completion thread
> 2014-06-02 11:25:20,072:7144(0x1e08):ZOO_DEBUG@do_io@403: started IO thread
> 2014-06-02
> 11:25:20,072:7144(0x1e08):ZOO_DEBUG@get_next_server_in_reconfig@1148: [OLD]
> count=0 capacity=0 next=0 hasnext=0
> 2014-06-02
> 11:25:20,072:7144(0x1e08):ZOO_DEBUG@get_next_server_in_reconfig@1151: [NEW]
> count=1 capacity=16 next=0 hasnext=1
> 2014-06-02
> 11:25:20,072:7144(0x1e08):ZOO_DEBUG@get_next_server_in_reconfig@1160: Using
> next from NEW=192.168.39.43:5181
> 2014-06-02 11:25:20,072:7144(0x1e08):ZOO_DEBUG@zookeeper_interest@1992: [zk]
> connect()
> 2014-06-02 11:25:20,158:7144(0x1e08):ZOO_ERROR@handle_socket_error_msg@1847:
> Socket [192.168.39.43:5181] zk retcode=-4, errno=10035(Unknown error): failed
> to send a handshake packet: Unknown error
> 2014-06-02 11:25:20,158:7144(0x1e08):ZOO_DEBUG@handle_error@1595: Previous
> connection=[192.168.39.43:5181] delay=0
> 2014-06-02
> 11:25:20,158:7144(0x1e08):ZOO_DEBUG@get_next_server_in_reconfig@1148: [OLD]
> count=0 capacity=0 next=0 hasnext=0
> 2014-06-02
> 11:25:20,158:7144(0x1e08):ZOO_DEBUG@get_next_server_in_reconfig@1151: [NEW]
> count=1 capacity=16 next=0 hasnext=1
> 2014-06-02
> 11:25:20,158:7144(0x1e08):ZOO_DEBUG@get_next_server_in_reconfig@1160: Using
> next from NEW=192.168.39.43:5181
> 2014-06-02 11:25:20,158:7144(0x1e08):ZOO_DEBUG@zookeeper_interest@1992: [zk]
> connect()
> 2014-06-02 11:25:20,159:7144(0x1e08):ZOO_ERROR@handle_socket_error_msg@1847:
> Socket [192.168.39.43:5181] zk retcode=-4, errno=10035(Unknown error): failed
> to send a handshake packet: Unknown error
> 2014-06-02 11:25:20,159:7144(0x1e08):ZOO_DEBUG@handle_error@1595: Previous
> connection=[192.168.39.43:5181] delay=0
> 2014-06-02
> 11:25:20,159:7144(0x1e08):ZOO_DEBUG@get_next_server_in_reconfig@1148: [OLD]
> count=0 capacity=0 next=0 hasnext=0
> 2014-06-02
> 11:25:20,159:7144(0x1e08):ZOO_DEBUG@get_next_server_in_reconfig@1151: [NEW]
> count=1 capacity=16 next=0 hasnext=1
> 2014-06-02
> 11:25:20,159:7144(0x1e08):ZOO_DEBUG@get_next_server_in_reconfig@1160: Using
> next from NEW=192.168.39.43:5181
> 2014-06-02 11:25:20,159:7144(0x1e08):ZOO_DEBUG@zookeeper_interest@1992: [zk]
> connect()
> 2014-06-02 11:25:20,159:7144(0x1e08):ZOO_ERROR@handle_socket_error_msg@1847:
> Socket [192.168.39.43:5181] zk retcode=-4, errno=10035(Unknown error): failed
> to send a handshake packet: Unknown error
> 2014-06-02 11:25:20,159:7144(0x1e08):ZOO_DEBUG@handle_error@1595: Previous
> connection=[192.168.39.43:5181] delay=0
> 2014-06-02
> 11:25:20,159:7144(0x1e08):ZOO_DEBUG@get_next_server_in_reconfig@1148: [OLD]
> count=0 capacity=0 next=0 hasnext=0
> 2014-06-02
> 11:25:20,159:7144(0x1e08):ZOO_DEBUG@get_next_server_in_reconfig@1151: [NEW]
> count=1 capacity=16 next=0 hasnext=1
> 2014-06-02
> 11:25:20,159:7144(0x1e08):ZOO_DEBUG@get_next_server_in_reconfig@1160: Using
> next from NEW=192.168.39.43:5181
> 2014-06-02 11:25:20,159:7144(0x1e08):ZOO_DEBUG@zookeeper_interest@1992: [zk]
> connect()
> {code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
