[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14080698#comment-14080698
 ] 

Hadoop QA commented on ZOOKEEPER-2000:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12658866/ZOOKEEPER-2000.patch
  against trunk revision 1613553.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 7 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 2.0.3) 
warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2250//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2250//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2250//console

This message is automatically generated.

> Fix ReconfigTest.testPortChange
> -------------------------------
>
>                 Key: ZOOKEEPER-2000
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2000
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: tests
>    Affects Versions: 3.5.0
>            Reporter: Alexander Shraer
>            Assignee: Alexander Shraer
>            Priority: Minor
>             Fix For: 3.5.0
>
>         Attachments: ZOOKEEPER-2000.patch
>
>
> testPortChange changes all ports and role of the server and thus causes 
> existing clients to disconnect, while this wouldn't happen if only the client 
> port changes. Need to fix it to only change client port and not all the other 
> parameters and make sure that the clients don't disconnect, while new clients 
> shouldn't be able to connect to the old port.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to