[
https://issues.apache.org/jira/browse/BOOKKEEPER-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14110313#comment-14110313
]
Rakesh R commented on BOOKKEEPER-736:
-------------------------------------
Thanks Sijie, latest patch looks better.
There are few more comments from me. Sorry, I failed to include this previously.
# It would be better to categorize success and failure based on the re-replica
operation. For this, please modify rereplicate(long ledgerIdToReplicate) method
by returning boolean status. Then return 'true' only if the
underreplicationManager.markLedgerReplicated(ledgerIdToReplicate); call
succeeds, all other places we can return 'false'.
# Should we retain the existing constructors for ReplicationWorker,
AuditorElector. I couldn't see any usage of these, please remove.
> Stats for AutoRecovery
> ----------------------
>
> Key: BOOKKEEPER-736
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-736
> Project: Bookkeeper
> Issue Type: New Feature
> Components: bookkeeper-auto-recovery
> Reporter: Rakesh R
> Assignee: Sijie Guo
> Fix For: 4.3.0
>
> Attachments: BOOKKEEPER-736.patch, BOOKKEEPER-736.v2.patch,
> BOOKKEEPER-736.v3.patch,
> Prototype-JMX-beans-for-standalone-autorecovery-process.png
>
>
> Idea of this JIRA is to provide jmx interfaces to get the statistics of the
> auto recovery activities.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
