[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14124788#comment-14124788
 ] 

Hadoop QA commented on ZOOKEEPER-2030:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12667065/ZOOKEEPER-2030.patch
  against trunk revision 1621313.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified 
tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 2.0.3) 
warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2316//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2316//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2316//console

This message is automatically generated.

> dynamicConfigFile should have an absolute path, not a relative path, to the 
> dynamic configuration file
> ------------------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2030
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2030
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.5.0
>            Reporter: Alexander Shraer
>            Assignee: Alexander Shraer
>            Priority: Minor
>         Attachments: ZOOKEEPER-2030.patch
>
>
> a relative path doesn't seem like a good idea since it will work only if we 
> start the server from the same directory as we did previously.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to