[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14128521#comment-14128521
 ] 

Hadoop QA commented on ZOOKEEPER-2026:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12667661/ZOOKEEPER-2026.patch
  against trunk revision 1623916.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 2.0.3) 
warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2324//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2324//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2324//console

This message is automatically generated.

> Startup order in ServerCnxnFactory-ies is wrong
> -----------------------------------------------
>
>                 Key: ZOOKEEPER-2026
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2026
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: java client
>    Affects Versions: 3.4.6, 3.5.0
>            Reporter: Stevo Slavic
>            Priority: Minor
>             Fix For: 3.4.7, 3.5.1
>
>         Attachments: ZOOKEEPER-2026.patch, ZOOKEEPER-2026.patch
>
>
> {{NIOServerCnxnFactory}} and {{NettyServerCnxnFactory}} {{startup}} method 
> implementations are binding {{ZooKeeperServer}} too late, so in 
> {{ZooKeeperServer}} in its startup can fail to register appropriate JMX MBean.
> See 
> [this|http://mail-archives.apache.org/mod_mbox/zookeeper-user/201409.mbox/%3CCAAUywg9-ad3oWfqRWahB9PyBEbg6%2Bd%3DDyj5PAUU7A%3Dm9wRncaw%40mail.gmail.com%3E]
>  post on ZK user mailing list for more details.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to