[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14220211#comment-14220211
 ] 

Hadoop QA commented on ZOOKEEPER-2064:
--------------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12682763/ZOOKEEPER-2064.patch
  against trunk revision 1640635.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 6 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 2.0.3) 
warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2441//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2441//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2441//console

This message is automatically generated.

> Prevent resource leak in various classes
> ----------------------------------------
>
>                 Key: ZOOKEEPER-2064
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2064
>             Project: ZooKeeper
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>            Priority: Critical
>             Fix For: 3.4.7, 3.5.1, 3.6.0
>
>         Attachments: 2064-v1.txt, 2064-v2.txt, ZOOKEEPER-2064.patch
>
>
> In various classes, there is potential resource leak.
> e.g. LogIterator / RandomAccessFileReader is not closed upon return from the 
> method.
> Corresponding close() should be called to prevent resource leak.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to