> On Dec. 11, 2014, 7:37 p.m., Rakesh R wrote: > > src/java/main/org/apache/zookeeper/ClientCnxnSocketNetty.java, line 99 > > <https://reviews.apache.org/r/27244/diff/28/?file=789550#file789550line99> > > > > Could you tell me when this situation can come? Is this added for safer > > side?
I will remove it. I had this code for safe check when I didn't know ClientCnxn so well. > On Dec. 11, 2014, 7:37 p.m., Rakesh R wrote: > > src/java/main/org/apache/zookeeper/ClientCnxnSocketNetty.java, line 63 > > <https://reviews.apache.org/r/27244/diff/28/?file=789550#file789550line63> > > > > Can you give thread name for this thread pool like, > > > > Executors.newCachedThreadPool(new ThreadFactoryBuilder() > > .setNameFormat("ZooKeeper-NIOBoss-%d").build()), > > Executors.newCachedThreadPool(new ThreadFactoryBuilder() > > .setNameFormat("ZooKeeper-NIOWorker-%d").build()) ThreadFactoryBuilder is from Guava... We didn't have it yet. > On Dec. 11, 2014, 7:37 p.m., Rakesh R wrote: > > src/java/main/org/apache/zookeeper/ClientCnxnSocketNetty.java, line 108 > > <https://reviews.apache.org/r/27244/diff/28/?file=789550#file789550line108> > > > > bootstrap.setOption("connectTimeoutMillis", > > System.getProperty("connectTimeoutMillis")); > > > > What do you think about providing 'clientConnectTimeoutMillis' as a > > configurable item. By default its 10secs. Sounds good. But currently the timeout thing is handled outside in ClientCnxn sendThread. This SSL thing will gradually drive transformation to Netty style connection :) - Hongchao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27244/#review64767 ----------------------------------------------------------- On Dec. 11, 2014, 6:11 p.m., Hongchao Deng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27244/ > ----------------------------------------------------------- > > (Updated Dec. 11, 2014, 6:11 p.m.) > > > Review request for zookeeper. > > > Repository: zookeeper-git > > > Description > ------- > > ZOOKEEPER-2069 > > > Diffs > ----- > > build.xml bb5ff4f > src/java/main/org/apache/zookeeper/ClientCnxn.java b4ece07 > src/java/main/org/apache/zookeeper/ClientCnxnSocket.java 5ca0ba7 > src/java/main/org/apache/zookeeper/ClientCnxnSocketNIO.java adb27ee > src/java/main/org/apache/zookeeper/ClientCnxnSocketNetty.java PRE-CREATION > src/java/main/org/apache/zookeeper/ZooKeeperTestable.java 775d1a2 > src/java/main/org/apache/zookeeper/client/ZooKeeperSaslClient.java dbc1080 > src/java/test/org/apache/zookeeper/test/ClientTest.java dbe595c > src/java/test/org/apache/zookeeper/test/NettyNettySuiteBase.java > PRE-CREATION > src/java/test/org/apache/zookeeper/test/NettyNettySuiteHammerTest.java > PRE-CREATION > src/java/test/org/apache/zookeeper/test/NettyNettySuiteTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/27244/diff/ > > > Testing > ------- > > 1. use LinkedBlockingDeque. > > > Thanks, > > Hongchao Deng > >
