[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14250814#comment-14250814
 ] 

Hongchao Deng commented on ZOOKEEPER-2069:
------------------------------------------

Thanks [~iandi]. Good to have you and other guys help testing it in live.

Since [~rakeshr] is familiar with ClientCnxn code, it would be great to have 
you take a look at the latest too :)
https://reviews.apache.org/r/27244/diff/#

Update to the last thing you comment:
1. change ClientCnxn.cleanup() to use iterator.
2. minor fix on formatting, comments.

> Netty Support for ClientCnxnSocket
> ----------------------------------
>
>                 Key: ZOOKEEPER-2069
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2069
>             Project: ZooKeeper
>          Issue Type: Sub-task
>            Reporter: Hongchao Deng
>            Assignee: Hongchao Deng
>         Attachments: QA-run-nettyclient-for-test.patch, 
> ZOOKEEPER-2069-v10-channel.patch, ZOOKEEPER-2069-v11.patch, 
> ZOOKEEPER-2069-v12.patch, ZOOKEEPER-2069-v14.patch, 
> ZOOKEEPER-2069-v15-jdk6.patch, ZOOKEEPER-2069-v15-jdk6.patch, 
> ZOOKEEPER-2069-v16.patch, ZOOKEEPER-2069-v17.patch, ZOOKEEPER-2069-v2.patch, 
> ZOOKEEPER-2069-v3.patch, ZOOKEEPER-2069-v4.patch, ZOOKEEPER-2069-v5.patch, 
> ZOOKEEPER-2069-v6.patch, ZOOKEEPER-2069-v7.patch, ZOOKEEPER-2069-v8.patch, 
> ZOOKEEPER-2069-v9.1.patch, ZOOKEEPER-2069-v9.2.patch, 
> ZOOKEEPER-2069-v9.patch, ZOOKEEPER-2069.patch, draft.patch
>
>
> Review Board: https://reviews.apache.org/r/27244/diff/#



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to