[
https://issues.apache.org/jira/browse/ZOOKEEPER-1784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291032#comment-14291032
]
Hudson commented on ZOOKEEPER-1784:
-----------------------------------
FAILURE: Integrated in ZooKeeper-trunk #2574 (See
[https://builds.apache.org/job/ZooKeeper-trunk/2574/])
ZOOKEEPER-1784 wrong check for COMMITANDACTIVATE in observer code, Learner.java
(rgs via shralex). (shralex:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1654608)
* /zookeeper/trunk/CHANGES.txt
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/Learner.java
> Logic to process INFORMANDACTIVATE packets in syncWithLeader seems bogus
> ------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1784
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1784
> Project: ZooKeeper
> Issue Type: Bug
> Affects Versions: 3.5.0
> Reporter: Raul Gutierrez Segales
> Assignee: Raul Gutierrez Segales
> Fix For: 3.5.1
>
> Attachments: ZOOKEEPER-1784.patch, ZOOKEEPER-1784.patch
>
>
> If you look at Learner#syncWithLeader:
> {noformat}
> while (self.isRunning()) {
> readPacket(qp);
> switch(qp.getType()) {
> .......
> case Leader.INFORM:
> case Leader.INFORMANDACTIVATE:
> PacketInFlight packet = new PacketInFlight();
> packet.hdr = new TxnHeader();
> if (qp.getType() == Leader.COMMITANDACTIVATE) {
> {noformat}
> I guess "qp.getType() == Leader.COMMITANDACTIVATE" is a typo that should read
> "qp.getType() == Leader.INFORMANDACTIVATE".
> Assigning to Alexander for now since this is part of ZOOKEEPER-107.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
