-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20071/
-----------------------------------------------------------
(Updated Jan. 26, 2015, 2:12 p.m.)
Review request for zookeeper, michim, Raul Gutierrez Segales, and Camille
Fournier.
Changes
-------
Attached new patch where I've tried another better approach. Introduced
ZooKeeperServerListener - will notify the critical resource(thread) failures
and act upon. Appreciate any comments. Thanks!
Bugs: ZOOKEEPER-1907
https://issues.apache.org/jira/browse/ZOOKEEPER-1907
Repository: zookeeper
Description
-------
Improve the thread handling mechanism by detecting if any of the critical
thread dies.
Here the idea is to periodically checking the status of all the critical
threads in ZK server using DeathWatcherThread.
Diffs (updated)
-----
./src/java/main/org/apache/zookeeper/server/ExitCode.java PRE-CREATION
./src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java 1654804
./src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java 1654804
./src/java/main/org/apache/zookeeper/server/SyncRequestProcessor.java 1654804
./src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 1654804
./src/java/main/org/apache/zookeeper/server/ZooKeeperServerListener.java
PRE-CREATION
./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java
1654804
./src/java/main/org/apache/zookeeper/server/quorum/FollowerRequestProcessor.java
1654804
./src/java/main/org/apache/zookeeper/server/quorum/FollowerZooKeeperServer.java
1654804
./src/java/main/org/apache/zookeeper/server/quorum/LeaderSessionTracker.java
1654804
./src/java/main/org/apache/zookeeper/server/quorum/LeaderZooKeeperServer.java
1654804
./src/java/main/org/apache/zookeeper/server/quorum/LearnerSessionTracker.java
1654804
./src/java/main/org/apache/zookeeper/server/quorum/LearnerZooKeeperServer.java
1654804
./src/java/main/org/apache/zookeeper/server/quorum/LocalSessionTracker.java
1654804
./src/java/main/org/apache/zookeeper/server/quorum/ObserverRequestProcessor.java
1654804
./src/java/main/org/apache/zookeeper/server/quorum/ObserverZooKeeperServer.java
1654804
./src/java/main/org/apache/zookeeper/server/quorum/ProposalRequestProcessor.java
1654804
./src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyRequestProcessor.java
1654804
./src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyZooKeeperServer.java
1654804
./src/java/main/org/apache/zookeeper/server/quorum/UpgradeableSessionTracker.java
1654804
./src/java/test/org/apache/zookeeper/server/PrepRequestProcessorTest.java
1654804
./src/java/test/org/apache/zookeeper/server/SessionTrackerTest.java 1654804
./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorConcurrencyTest.java
1654804
./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorTest.java
1654804
./src/java/test/org/apache/zookeeper/test/ClientBase.java 1654804
./src/java/test/org/apache/zookeeper/test/SessionTrackerCheckTest.java
1654804
Diff: https://reviews.apache.org/r/20071/diff/
Testing
-------
yet to be inlcuded
Thanks,
Rakesh R