[ https://issues.apache.org/jira/browse/ZOOKEEPER-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14301410#comment-14301410 ]
Hongchao Deng commented on ZOOKEEPER-2094: ------------------------------------------ Hi [~iandi]. I have reviewed the patch. Great work! A few things is needed first: 1. Can you upload the patch to review board? 2. The patch failed to be applied. The auth data (i.e. certs) isn't there. > SSL support for NettyServerCnxnFactory > -------------------------------------- > > Key: ZOOKEEPER-2094 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2094 > Project: ZooKeeper > Issue Type: Sub-task > Components: server > Affects Versions: 3.4.6, 3.5.0 > Reporter: Ian Dimayuga > Assignee: Ian Dimayuga > Fix For: 3.5.1 > > Attachments: ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, > ZOOKEEPER-2094.patch > > > Add SSL handler to Netty pipeline, and a default X509AuthenticationProvider > to perform authentication. -- This message was sent by Atlassian JIRA (v6.3.4#6332)