[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14328548#comment-14328548
 ] 

Hadoop QA commented on ZOOKEEPER-1952:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12699806/ZOOKEEPER-1952-5.patch
  against trunk revision 1658888.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified 
tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 2.0.3) 
warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2522//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2522//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2522//console

This message is automatically generated.

> Default log directory and file name can be changed
> --------------------------------------------------
>
>                 Key: ZOOKEEPER-1952
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1952
>             Project: ZooKeeper
>          Issue Type: Bug
>    Affects Versions: 3.4.6
>            Reporter: nijel
>            Assignee: nijel
>            Priority: Minor
>             Fix For: 3.5.1
>
>         Attachments: ZOOKEEPER-1952-1.patch, ZOOKEEPER-1952-2.patch, 
> ZOOKEEPER-1952-3.patch, ZOOKEEPER-1952-4.patch, ZOOKEEPER-1952-5.patch
>
>
> The log folder and log file name is configurable now.
> The default log folder is "." in distribution. So the log file 
> (zookeeper.out) will be placed in bin folder
> Can this be changed to <zk_home>/logs/zookeeperserver-<hostname>.log ?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to