[ https://issues.apache.org/jira/browse/ZOOKEEPER-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14335990#comment-14335990 ]
Hadoop QA commented on ZOOKEEPER-1846: -------------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12700668/DynamicIP.java.patch against trunk revision 1662055. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2534//console This message is automatically generated. > Cached InetSocketAddresses prevent proper dynamic DNS resolution > ---------------------------------------------------------------- > > Key: ZOOKEEPER-1846 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1846 > Project: ZooKeeper > Issue Type: Bug > Components: quorum > Affects Versions: 3.4.6 > Reporter: Benjamin Jaton > Priority: Minor > Labels: patch > Attachments: DynamicIP.java.patch, Learner.java, > QuorumCnxManager.java, QuorumPeer.java > > > The class QuorumPeer maintains a Map<Long, QuorumServer> quorumPeers. > Each QuorumServer is created with an instance of InetSocketAddress > electionAddr, and holds it forever. > I believe this is why the ZooKeeper servers can't resolve each other > dynamically: If a ZooKeeper in the ensemble cannot be resolved at startup, it > will never be resolved (until restart of the JVM), constantly failing with an > UnknownHostException, even when the node is back up and reachable. > I would suggest to recreate an InetSocketAddress every time we retry the > connection. -- This message was sent by Atlassian JIRA (v6.3.4#6332)