[
https://issues.apache.org/jira/browse/ZOOKEEPER-2146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14378989#comment-14378989
]
Hadoop QA commented on ZOOKEEPER-2146:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12707053/ZOOKEEPER-2146.patch
against trunk revision 1667358.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 2 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2587//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2587//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2587//console
This message is automatically generated.
> BinaryInputArchive readString should check length before allocating memory
> --------------------------------------------------------------------------
>
> Key: ZOOKEEPER-2146
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2146
> Project: ZooKeeper
> Issue Type: Bug
> Reporter: Hongchao Deng
> Assignee: Hongchao Deng
> Attachments: ZOOKEEPER-2146.patch, ZOOKEEPER-2146.patch,
> ZOOKEEPER-2146.patch, ZOOKEEPER-2146.patch, ZOOKEEPER-2146.patch
>
>
> I recently observed a problem caused by malformed packets. ZK server crashed
> because of OutOfMemoryError.
> The reason is BinaryInputArchive didn't check the length before allocating
> memory in readString():
> {code}
> public String readString(String tag) throws IOException {
> int len = in.readInt();
> if (len == -1) return null;
> byte b[] = new byte[len];
> ...
> {code}
> I suggest to add the same check as in readBuffer.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
