[
https://issues.apache.org/jira/browse/ZOOKEEPER-2174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Nauroth updated ZOOKEEPER-2174:
-------------------------------------
Attachment: ZOOKEEPER-2174.003.patch
[~rakeshr], thank you for your code review. Here is patch v003. I took the
opportunity to convert all logging statements in the class to slf4j
parameterized messages where possible. For the statement that logs the full
exception, I think we're stuck with string concatenation, because slf4j doesn't
offer a method that accepts both a parameterized message and an exception at
the same time.
> JUnit4ZKTestRunner logs test failure for all exceptions even if the test
> method is annotated with an expected exception.
> ------------------------------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-2174
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2174
> Project: ZooKeeper
> Issue Type: Bug
> Components: tests
> Reporter: Chris Nauroth
> Assignee: Chris Nauroth
> Priority: Minor
> Fix For: 3.4.7, 3.5.2, 3.6.0
>
> Attachments: ZOOKEEPER-2174.001.patch, ZOOKEEPER-2174.002.patch,
> ZOOKEEPER-2174.003.patch
>
>
> {{JUnit4ZKTestRunner}} wraps JUnit test method execution, and if any
> exception is thrown, it logs a message stating that the test failed.
> However, some ZooKeeper tests are annotated with {{@Test(expected=...)}} to
> indicate that an exception is the expected result, and thus the test passes.
> The runner should be aware of expected exceptions and only log if an
> unexpected exception occurs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
