[
https://issues.apache.org/jira/browse/ZOOKEEPER-2174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14508496#comment-14508496
]
Hadoop QA commented on ZOOKEEPER-2174:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12727532/ZOOKEEPER-2174.004.patch
against trunk revision 1672934.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2647//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2647//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2647//console
This message is automatically generated.
> JUnit4ZKTestRunner logs test failure for all exceptions even if the test
> method is annotated with an expected exception.
> ------------------------------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-2174
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2174
> Project: ZooKeeper
> Issue Type: Bug
> Components: tests
> Reporter: Chris Nauroth
> Assignee: Chris Nauroth
> Priority: Minor
> Fix For: 3.4.7, 3.5.2, 3.6.0
>
> Attachments: ZOOKEEPER-2174.001.patch, ZOOKEEPER-2174.002.patch,
> ZOOKEEPER-2174.003.patch, ZOOKEEPER-2174.004.patch
>
>
> {{JUnit4ZKTestRunner}} wraps JUnit test method execution, and if any
> exception is thrown, it logs a message stating that the test failed.
> However, some ZooKeeper tests are annotated with {{@Test(expected=...)}} to
> indicate that an exception is the expected result, and thus the test passes.
> The runner should be aware of expected exceptions and only log if an
> unexpected exception occurs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
