[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14511039#comment-14511039
 ] 

Eugene Koontz commented on ZOOKEEPER-2159:
------------------------------------------

Hi Yuliya,
I have had a chance to look at the overall design on the review board and it 
looks good. As you said, it makes sense to create an abstract AuthMethod which 
can be subclassed (e.g. to DIGEST-MD5, KRB5, etc) rather than having a bunch of 
if ..else .. blocks as we do currently. I would like to test it with my own 
local kerberos setup and hopefully have some more helpful detailed comments 
which I will put in the review board this weekend.

> Pluggable SASL Authentication
> -----------------------------
>
>                 Key: ZOOKEEPER-2159
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2159
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: java client, server
>            Reporter: Yuliya Feldman
>            Assignee: Yuliya Feldman
>         Attachments: PluggableZookeeperAuthentication (1).pdf, 
> PluggableZookeeperAuthentication.pdf
>
>
> Today SASLAuthenticationProvider is used for all SASL based authentications 
> which creates some "if/else" statements in ZookeeperSaslClient and 
> ZookeeperSaslServer code with just Kerberos and Digest.
> We want to use yet another different SASL based authentication and adding one 
> more "if/else" with some code specific just to that new way does not make 
> much sense.
> Proposal is to allow to plug custom SASL Authentication mechanism(s) without  
> further changes in Zookeeper code.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to