[
https://issues.apache.org/jira/browse/ZOOKEEPER-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14555631#comment-14555631
]
Chris Nauroth commented on ZOOKEEPER-2194:
------------------------------------------
bq. -1 core tests. The patch failed core unit tests.
This was an unrelated failure in one of the CppUnit tests. It was one of the
reconfig tests, which have been failing intermittently.
> Let DataNode.getChildren() return an unmodifiable view of its children set
> --------------------------------------------------------------------------
>
> Key: ZOOKEEPER-2194
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2194
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
> Reporter: Hitoshi Mitake
> Priority: Trivial
> Attachments: ZOOKEEPER-2194-v2.patch, ZOOKEEPER-2194.patch
>
>
> Current DataNode.getChildren() directly returns a pointer of its private
> member, children. However, the member should be modified through addChild()
> and removeChild(). Callers of getChildren() shouldn't modify it directly.
> For preventing the direct modification by the callers, this patch lets
> getChildren() return an unmodifiable view of its children set. If the callers
> try to modify directly, runtime exception will be risen.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
