[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14569610#comment-14569610
 ] 

Vitaly Stakhovsky commented on ZOOKEEPER-2096:
----------------------------------------------

I just learned that there is actually an automated build: 
https://builds.apache.org/job/ZooKeeper-trunk-WinVS2008/ .
Somehow it is not shown in the usual report. It was failing for a long time 
(see ZOOKEEPER-2178).
Would it be possible to set up similar build for MSVC2010+ ? And actually run 
it ?

> C client builds with incorrect error codes in VisualStudio 2010+
> ----------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2096
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2096
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: build, c client
>    Affects Versions: 3.4.6, 3.5.0
>         Environment: Windows MSVS 2010+
>            Reporter: Vitaly Stakhovsky
>             Fix For: 3.4.7, 3.5.1, 3.6.0
>
>         Attachments: ZOOKEEPER-2096.patch, ZOOKEEPER-2096.patch, 
> ZOOKEEPER-2096.patch, ZOOKEEPER-2096.patch, ZOOKEEPER-2096.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> It reports:
> warning C4005: 'EWOULDBLOCK' : macro redefinition
> warning C4005: 'EINPROGRESS' : macro redefinition
> In MSVS 2010+, these constants are now in <errno.h>.
> What's worse, they have different numeric values.
> Possible fix:
> In "src/c/include/winconfig.h" :
> #if _MSC_VER < 1600
> #define EWOULDBLOCK WSAEWOULDBLOCK
> #define EINPROGRESS WSAEINPROGRESS
> #endif



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to