[ https://issues.apache.org/jira/browse/ZOOKEEPER-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14572339#comment-14572339 ]
Hitoshi Mitake commented on ZOOKEEPER-2205: ------------------------------------------- I found the below branch in the head of packetToString(): {code} if (true) return null; {code} Is there any reason for avoiding the method? The conditional branch seems to exist since the commit of "Initial import". > Log type of unexpected quorum packet in learner handler loop > ------------------------------------------------------------ > > Key: ZOOKEEPER-2205 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2205 > Project: ZooKeeper > Issue Type: Improvement > Components: server > Reporter: Hitoshi Mitake > Assignee: Hitoshi Mitake > Priority: Trivial > Attachments: ZOOKEEPER-2205-v2.patch, ZOOKEEPER-2205.patch > > > Current learner handler loop doesn't log anything when it receives unexpected > type of quorum packet from learner. > This patch lets the learner handler loop log the type of packet for defensive > purpose. It would make debugging and trouble shooting a little bit easier. -- This message was sent by Atlassian JIRA (v6.3.4#6332)