[jira] [Commented] (ZOOKEEPER-2193) reconfig command completes even if parameter is wrong obviously

[Raul Gutierrez Segales (JIRA)]

    [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14595276#comment-14595276
 ] 

Raul Gutierrez Segales commented on ZOOKEEPER-2193:
---------------------------------------------------

One last nit, in:

{code}
+                if (inetaddr == null) {
+                    continue;
+                // wildCard address(0.0.0.0)
+                } else if (inetaddr.equals(wcAddr)) {
+                    continue;
+                // loopback address(localhost/127.0.0.1)
+                } else if (inetaddr.isLoopbackAddress()) {
+                    continue;
+                } else {
+                    included.add(addr);
+                }
{code}

you could simplify things a bit by having:

{code}
                if (inetaddr == null ||
                    inetaddr.equals(wcAddr) ||
                    inetaddr.isLoopbackAddress()) {
                      continue;
                }

                included.add(addr);
{code}

Thanks again!

> reconfig command completes even if parameter is wrong obviously
> ---------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2193
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2193
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: leaderElection, server
>    Affects Versions: 3.5.0
>         Environment: CentOS7 + Java7
>            Reporter: Yasuhito Fukuda
>            Assignee: Yasuhito Fukuda
>         Attachments: ZOOKEEPER-2193-v2.patch, ZOOKEEPER-2193-v3.patch, 
> ZOOKEEPER-2193-v4.patch, ZOOKEEPER-2193-v5.patch, ZOOKEEPER-2193-v6.patch, 
> ZOOKEEPER-2193-v7.patch, ZOOKEEPER-2193.patch
>
>
> Even if reconfig parameter is wrong, it was confirmed to complete.
> refer to the following.
> - Ensemble consists of four nodes
> {noformat}
> [zk: vm-101:2181(CONNECTED) 0] config
> server.1=192.168.100.101:2888:3888:participant
> server.2=192.168.100.102:2888:3888:participant
> server.3=192.168.100.103:2888:3888:participant
> server.4=192.168.100.104:2888:3888:participant
> version=100000000
> {noformat}
> - add node by reconfig command
> {noformat}
> [zk: vm-101:2181(CONNECTED) 9] reconfig -add 
> server.5=192.168.100.104:2888:3888:participant;0.0.0.0:2181
> Committed new configuration:
> server.1=192.168.100.101:2888:3888:participant
> server.2=192.168.100.102:2888:3888:participant
> server.3=192.168.100.103:2888:3888:participant
> server.4=192.168.100.104:2888:3888:participant
> server.5=192.168.100.104:2888:3888:participant;0.0.0.0:2181
> version=300000007
> {noformat}
> server.4 and server.5 of the IP address is a duplicate.
> In this state, reader election will not work properly.
> Besides, it is assumed an ensemble will be undesirable state.
> I think that need a parameter validation when reconfig.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)