[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14604098#comment-14604098
 ] 

Rakesh R commented on ZOOKEEPER-2221:
-------------------------------------

Thanks [~surendrasingh] for the contribution. Few minor comments:

# Can we rename the property {{zookeeper.admin.address}} to 
{{zookeeper.admin.serverAddress}} to sync with other configurations in 
JettyAdminServer.java. I could see already we have a configuration for the port 
its name is {{zookeeper.admin.serverPort}}
# Also, please move the new configuration reading logic to default 
{{JettyAdminServer()}} constructor

> Zookeeper JettyAdminServer server should start on configured IP.
> ----------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2221
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2221
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: quorum
>    Affects Versions: 3.5.0
>            Reporter: Surendra Singh Lilhore
>            Assignee: Surendra Singh Lilhore
>         Attachments: ZOOKEEPER-2221.patch
>
>
> Currently JettyAdminServer starting on "0.0.0.0" IP. "0.0.0.0" means "all IP 
> addresses on the local machine". So, if your webserver machine has two ip 
> addresses, 192.168.1.1(private) and 10.1.2.1(public), and you allow a 
> webserver daemon like apache to listen on 0.0.0.0, it will be reachable at 
> both of those IPs.
> This is security issue. webserver should be accessible from only configured IP



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to