[ https://issues.apache.org/jira/browse/ZOOKEEPER-2218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14607525#comment-14607525 ]
Hadoop QA commented on ZOOKEEPER-2218: -------------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12742708/ZOOKEEPER-2218.patch against trunk revision 1688041. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 120 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The patch appears to cause tar ant target to fail. -1 findbugs. The patch appears to cause Findbugs (version 2.0.3) to fail. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2787//testReport/ Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2787//console This message is automatically generated. > Close IO Streams in finally block > --------------------------------- > > Key: ZOOKEEPER-2218 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2218 > Project: ZooKeeper > Issue Type: Bug > Reporter: Tang Xinye > Assignee: Bill Havanki > Priority: Critical > Attachments: ZOOKEEPER-2218.patch, ZOOKEEPER-2218.patch > > > The problem here is that if an exception is thrown during the read process > the method will exit without closing the stream and hence without releasing > the file system resources, it may run out of resources before it does run. -- This message was sent by Atlassian JIRA (v6.3.4#6332)