[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14608989#comment-14608989
 ] 

Chris Nauroth commented on ZOOKEEPER-2224:
------------------------------------------

Hi Arshad.  Nice catch!  Here are a few more comments.

# The current patch is starting the SSL handshake before connecting the socket. 
 Is that the cause of the test failures?
# It looks like there is a small typo with {{DEFAUL_SOCKET_TIMEOUT}} missing 
the 'T' in "DEFAULT".
# Is the null check on {{host}} and special case for the loopback address 
required?  It seems {{host}} cannot be null here, because {{main}} enforces the 
expected number of arguments.
# The test also appears to have a small typo: {{timout}} instead of {{timeout}}.
# Is it necessary for the test to create and close {{zk1}}?  The test runs 
{{isro}}, which just reports server read-only state, so I don't think there is 
a dependency on any established client sessions.

Thank you!

> Four letter command hangs when network is slow
> ----------------------------------------------
>
>                 Key: ZOOKEEPER-2224
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2224
>             Project: ZooKeeper
>          Issue Type: Bug
>            Reporter: Arshad Mohammad
>            Assignee: Arshad Mohammad
>            Priority: Minor
>             Fix For: 3.6.0
>
>         Attachments: ZOOKEEPER-2224-01.patch
>
>
> Four letter command hangs when network is slow or network goes down in 
> between the operation, and the application also, which calling this four 
> letter command,  hangs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to