[
https://issues.apache.org/jira/browse/ZOOKEEPER-2253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14735239#comment-14735239
]
Hadoop QA commented on ZOOKEEPER-2253:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12754676/zookeeper-2253-3.4.patch
against trunk revision 1701505.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
-1 patch. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2864//console
This message is automatically generated.
> C asserts ordering of ping requests, while Java client does not
> ---------------------------------------------------------------
>
> Key: ZOOKEEPER-2253
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2253
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.5.0
> Reporter: Chris Chen
> Attachments: ZOOKEEPER-2253.patch, ZOOKEEPER-2253.patch,
> ZOOKEEPER-2253.patch, zookeeper-2253-3.4.patch
>
>
> Affects C clients from 3.3 to trunk.
> The Java client does not enforce ordering on ping requests. It merely updates
> fields when a ping reply is received and schedules a new ping request when
> necessary.
> The C client actually enqueues the void response in the completion data
> structure and pulls it off when it gets a response.
> This sounds like an implementation detail (and it is, sort of), but if a
> future server were to, say, send unsolicited ping replies to a client to
> assert liveness, it would work fine against a Java client but would cause a C
> client to fail the assertion in zookeeper_process, "assert(cptr)", line 2912,
> zookeeper.c.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
