[
https://issues.apache.org/jira/browse/ZOOKEEPER-2272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14739209#comment-14739209
]
Arshad Mohammad commented on ZOOKEEPER-2272:
--------------------------------------------
{quote}
-1 core tests. The patch failed core unit tests.
{quote}
One test case is skipped but that is not related to this patch
> Code clean up in ZooKeeperServer and KerberosName
> -------------------------------------------------
>
> Key: ZOOKEEPER-2272
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2272
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.5.0
> Reporter: Arshad Mohammad
> Assignee: Arshad Mohammad
> Priority: Trivial
> Fix For: 3.5.2
>
> Attachments: ZOOKEEPER-2272-01.patch
>
>
> # Following code in {{org.apache.zookeeper.server.ZooKeeperServer}} should be
> cleaned up. Some how it got missed in code review
> {code}
> if ((System.getProperty("zookeeper.allowSaslFailedClients") != null)
> &&
> (System.getProperty("zookeeper.allowSaslFailedClients").equals("true"))) {
> {code}
> should be replaced with
> {code}
> if(Boolean.getBoolean("zookeeper.allowSaslFailedClients"))
> {code}
> # Similar code clean up can be done in
> {{org.apache.zookeeper.server.auth.KerberosName}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
