[
https://issues.apache.org/jira/browse/ZOOKEEPER-1460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14876636#comment-14876636
]
Chris Nauroth commented on ZOOKEEPER-1460:
------------------------------------------
bq. Is there anything else I can do to get it fixed in ZK 3.5.0 ?
[~boying], you've been very helpful already, and thank you!
At this point, the plan is to wait for ZOOKEEPER-1506 to finish and get
committed first. Depending on the final outcome of the ZOOKEEPER-1506 patch,
we might need to rebase this once again and do another pre-commit test run.
After that, if you want to help more, then I suggest watching the
[email protected] list for an announcement of the next 3.5.x release
candidate. When that's published, you could download it, repeat your testing
with the release candidate, and then reply to [email protected] with a
+1 (or -1 if you found something wrong). That would give us confidence that
the fix made it into the release candidate correctly.
> IPv6 literal address not supported for quorum members
> -----------------------------------------------------
>
> Key: ZOOKEEPER-1460
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1460
> Project: ZooKeeper
> Issue Type: Bug
> Components: quorum
> Affects Versions: 3.4.3
> Reporter: Chris Dolan
> Assignee: Joseph Walton
> Attachments:
> ZOOKEEPER-1460-accept-square-bracket-delimited-IPv6-literals.2.diff,
> ZOOKEEPER-1460-accept-square-bracket-delimited-IPv6-literals.diff,
> ZOOKEEPER-1460-for-3.5.0.patch, ZOOKEEPER-1460.003.patch
>
>
> Via code inspection, I see that the "server.nnn" configuration key does not
> support literal IPv6 addresses because the property value is split on ":". In
> v3.4.3, the problem is in QuorumPeerConfig:
> {noformat}
> String parts[] = value.split(":");
> InetSocketAddress addr = new InetSocketAddress(parts[0],
> Integer.parseInt(parts[1]));
> {noformat}
> In the current trunk
> (http://svn.apache.org/viewvc/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java?view=markup)
> this code has been refactored into QuorumPeer.QuorumServer, but the bug
> remains:
> {noformat}
> String serverClientParts[] = addressStr.split(";");
> String serverParts[] = serverClientParts[0].split(":");
> addr = new InetSocketAddress(serverParts[0],
> Integer.parseInt(serverParts[1]));
> {noformat}
> This bug probably affects very few users because most will naturally use a
> hostname rather than a literal IP address. But given that IPv6 addresses are
> supported for clients via ZOOKEEPER-667 it seems that server support should
> be fixed too.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)