[
https://issues.apache.org/jira/browse/ZOOKEEPER-2211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14908578#comment-14908578
]
Arshad Mohammad commented on ZOOKEEPER-2211:
--------------------------------------------
Thanks a lot [~rakeshr] for your review comments
# handled
# Here "greater than 3" means at least 4, but as per the existing
functionality even 3 snap/logs can be retained. So I think message "greater
than 3" will be misleading. IMHO, "greater than or equal to 3" will be more
appropriate message. Changed the message to {code}System.out.println("\tcount
-- the number of old snaps/logs you want to keep, value should be greater than
or equal to 3");{code}
is this OK?
> PurgeTxnLog does not correctly purge when snapshots and logs are at different
> locations
> ---------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-2211
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2211
> Project: ZooKeeper
> Issue Type: Bug
> Components: scripts
> Affects Versions: 3.4.6, 3.5.0
> Environment: Ubuntu 12.04, Java 1.7.
> Reporter: Wesley Chow
> Assignee: Arshad Mohammad
> Fix For: 3.4.7, 3.5.2, 3.6.0
>
> Attachments: ZOOKEEPER-2211-02.patch, ZOOKEEPER-2211.patch
>
>
> PurgeTxnLog does not work when snapshots and transaction logs are at
> different file paths. The argument handling is buggy and only works when both
> snap and datalog dirs are given, and datalog dir contains both logs and snaps
> (snap is ignored).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
