[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14909970#comment-14909970
 ] 

Raul Gutierrez Segales commented on ZOOKEEPER-2244:
---------------------------------------------------

Hi [~cnauroth], [~arshad.mohammad] - one question, why do we need another 
waitFor*Connected method in 
src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java: 

{code}
+    protected synchronized boolean waitForClientConnect(ZooKeeper zk, long 
timeout)
+            throws InterruptedException {
+        connected = (zk.getState() == States.CONNECTED);
+        long end = Time.currentElapsedTime() + timeout;
+        while (!connected && end > Time.currentElapsedTime()) {
+            wait(timeout);
+            connected = (zk.getState() == States.CONNECTED);
+        }
+        return connected;
+    }
{code}

We have a few of those already.. can't we reuse one of those?

Other than that, lgtm. Thanks!

> On Windows zookeeper fails to restart.
> --------------------------------------
>
>                 Key: ZOOKEEPER-2244
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2244
>             Project: ZooKeeper
>          Issue Type: Bug
>    Affects Versions: 3.5.0
>            Reporter: Arshad Mohammad
>            Assignee: Arshad Mohammad
>            Priority: Critical
>             Fix For: 3.5.2
>
>         Attachments: ZOOKEEPER-2244-01.patch, ZOOKEEPER-2244-02.patch, 
> ZOOKEEPER-2244-03.patch, ZOOKEEPER-2244-04.patch
>
>
> This issue occurs in following scenario
> 1) configure server properties in  zookeeper configuration file(zoo.cfg)
> example:
> {code}
> server.1=localhost:43222:43225:participant;0.0.0.0:43228
> server.2=localhost:43223:43226:participant;0.0.0.0:43229
> server.3=localhost:43224:43227:participant;0.0.0.0:43230
> {code}
> 2)  start the servers on windows. All the servers started successfully
> 3) stop any of the server
> 4)  try to start the stopped server. It fails with following error
> {code}
> org.apache.zookeeper.server.quorum.QuorumPeerConfig$ConfigException: Error 
> processing D:SystemTestCasesZKServer1confzoo.cfg.dynamic.100000000
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to