[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14974479#comment-14974479
 ] 

Hadoop QA commented on ZOOKEEPER-2300:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12768744/ZOOKEEPER-2300-01.patch
  against trunk revision 1709293.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 2 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 2.0.3) 
warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2931//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2931//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2931//console

This message is automatically generated.

> Expose SecureClientPort and SecureClientAddress JMX properties
> --------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2300
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2300
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: jmx
>    Affects Versions: 3.5.0
>            Reporter: Arshad Mohammad
>            Assignee: Arshad Mohammad
>             Fix For: 3.5.2
>
>         Attachments: ZOOKEEPER-2300-01.patch
>
>
> ZooKeeper currently exposes ClientPort and ClientAddress JMX properties. 
> Same way we should expose SecureClientPort and SecureClientAddress.
> The values for these two properties will be decided based on the configured 
> value of secureClientPort and secureClientPortAddress
> The value of SecureClientPort will be:
> secureClientPort   {color:blue}(if secureClientPort is configured){color}
> empty string  {color:blue}(If secureClientPort is not configured){color}
> The value of SecureClientAddress will be:
> secureClientPortAddress:secureClientPort    {color:blue}(if both 
> secureClientPort and secureClientPortAddress are configured){color}
> 0.0.0.0:secureClientPort or 0:0:0:0:0:0:0:0:secureClientPort  {color:blue}(if 
> only secureClientPort is configured){color}
> empty string  {color:blue}(If secureClientPort is not configured){color}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to