[ https://issues.apache.org/jira/browse/ZOOKEEPER-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15000052#comment-15000052 ]
Hadoop QA commented on ZOOKEEPER-2139: -------------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12771703/ZOOKEEPER-2139-05.patch against trunk revision 1713320. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 17 new or modified tests. -1 javadoc. The javadoc tool appears to have generated 1 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2954//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2954//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2954//console This message is automatically generated. > Zookeeper client configuration should not be java system property > ----------------------------------------------------------------- > > Key: ZOOKEEPER-2139 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2139 > Project: ZooKeeper > Issue Type: Improvement > Components: java client > Affects Versions: 3.5.0 > Reporter: Surendra Singh Lilhore > Assignee: Arshad Mohammad > Fix For: 3.5.2, 3.6.0 > > Attachments: ZOOKEEPER-2139-05.patch, ZOOKEEPER-2139.patch, > ZOOKEEPER-2139.patch, ZOOKEEPER-2139_1.patch, ZOOKEEPER-2139_2.patch > > > I have two ZK client in one JVM, one is secure client and second is normal > client (For non secure cluster). > "zookeeper.sasl.client" system property is "true" by default, because of this > my second client connection is failing. > We should pass all client configurations in client constructor like HDFS > client. > For example : > {code} > public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher, > Configuration conf) throws IOException > { > ...... > ...... > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)