[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15020679#comment-15020679
 ] 

Hadoop QA commented on ZOOKEEPER-1371:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12773684/ZOOKEEPER-1371-05.patch
  against trunk revision 1715557.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 12 new or modified tests.

    -1 javadoc.  The javadoc tool appears to have generated 1 warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 2.0.3) 
warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2963//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2963//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2963//console

This message is automatically generated.

> Remove dependency on log4j in the source code.
> ----------------------------------------------
>
>                 Key: ZOOKEEPER-1371
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1371
>             Project: ZooKeeper
>          Issue Type: Bug
>    Affects Versions: 3.4.0, 3.4.1, 3.4.2, 3.4.3
>            Reporter: Mahadev konar
>            Assignee: Arshad Mohammad
>              Labels: patch
>             Fix For: 3.5.2, 3.6.0
>
>         Attachments: ZOOKEEPER-1371-05.patch, ZOOKEEPER-1371.patch, 
> ZOOKEEPER-1371.patch, ZOOKEEPER-1371.patch, ZOOKEEPER-1371.patch
>
>
> ZOOKEEPER-850 added slf4j to ZK. We still depend on log4j in our codebase. We 
> should remove the dependency on log4j so that we can make logging pluggable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to