[
https://issues.apache.org/jira/browse/ZOOKEEPER-412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Akihiro Suda updated ZOOKEEPER-412:
-----------------------------------
Attachment: ZOOKEEPER-412-v2.patch
Hi [~fpj] and [~rgs],
Thank you for comments.
I attached {{ZOOKEEPER-412-v2.patch}} with 4-space indentation.
I think the patch now comply with the original manner of Zookeeper.
(Note that {{DoubleCheckedLocking}} and {{RedundantThrows}} are not available
in latest Checkstyle.)
I will also submit a patch that actually fixes style errors after
{{ZOOKEEPER-412-v2.patch}} gets merged.
For precommit checking, of course it is possible to add the feature in
{{test-patch.sh}}.
However, perhaps this is a good chance to adopt Apache Yetus as in Hadoop.
I would like to hear your comments. (Cc: [~cnauroth])
Thanks!
> checkstyle target fails trunk build
> -----------------------------------
>
> Key: ZOOKEEPER-412
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-412
> Project: ZooKeeper
> Issue Type: Bug
> Reporter: Giridharan Kesavan
> Assignee: Akihiro Suda
> Attachments: ZOOKEEPER-412-v2.patch, ZOOKEEPER-412.patch,
> checkstyle-errors-trunk-20151211.html.gz
>
>
> BUILD FAILED
> /home/hudson/hudson-slave/workspace/ZooKeeper-trunk/trunk/build.xml:865:
> Unable to create a Checker: cannot initialize module PackageHtml - Unable to
> instantiate PackageHtml
> Tnx!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
