> On פבר' 10, 2016, 9:59 אחר הצהריים, Chris Conroy wrote: > > ./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java, > > line 98 > > <https://reviews.apache.org/r/25160/diff/12/?file=1239815#file1239815line98> > > > > shouldn't this be a concurrent map OR by `@GaurdedBy` an appropriate > > lock?
since it is solely used by the commit processor thread, we don't need an additional synchronization here. - Kfir ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25160/#review118732 ----------------------------------------------------------- On פבר' 11, 2016, 5:43 בבוקר, Kfir Lev-Ari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25160/ > ----------------------------------------------------------- > > (Updated פבר' 11, 2016, 5:43 בבוקר) > > > Review request for zookeeper, Raul Gutierrez Segales and Alexander Shraer. > > > Repository: zookeeper > > > Description > ------- > > Please see https://issues.apache.org/jira/browse/ZOOKEEPER-2024 > > > Diffs > ----- > > ./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java > 1726708 > > ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorConcurrencyTest.java > 1726708 > ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorTest.java > 1726708 > > Diff: https://reviews.apache.org/r/25160/diff/ > > > Testing > ------- > > The attached unit tests, as well as the system test found in > https://issues.apache.org/jira/browse/ZOOKEEPER-2023. > > > Thanks, > > Kfir Lev-Ari > >
