[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15185323#comment-15185323
]
Flavio Junqueira commented on ZOOKEEPER-2383:
---------------------------------------------
[~steve_rowe] Thanks for reporting this issue. According to git blame, the
latest changes around the startup method in ZooKeeperServer is due to
ZOOKEEPER-1907, which actually turned out to be quite problematic, so this
could be another issue due to that patch, I'm not sure.
{noformat}
91f579e4 src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java
(Hongchao Deng 2015-08-17 20:52:07 +0000 411) public synchronized
void startup() {
55b03fce src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java
(Mahadev Konar 2012-01-31 06:50:06 +0000 412) if
(sessionTracker == null) {
55b03fce src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java
(Mahadev Konar 2012-01-31 06:50:06 +0000 413)
createSessionTracker();
55b03fce src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java
(Mahadev Konar 2012-01-31 06:50:06 +0000 414) }
55b03fce src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java
(Mahadev Konar 2012-01-31 06:50:06 +0000 415)
startSessionTracker();
097b7979 zookeeper/java/src/com/yahoo/zookeeper/server/ZooKeeperServer.java
(Benjamin Reed 2008-05-12 23:01:25 +0000 416)
setupRequestProcessors();
87e1e030 src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java
(Patrick D. Hunt 2009-01-15 22:57:14 +0000 417)
87e1e030 src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java
(Patrick D. Hunt 2009-01-15 22:57:14 +0000 418) registerJMX();
87e1e030 src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java
(Patrick D. Hunt 2009-01-15 22:57:14 +0000 419)
91f579e4 src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java
(Hongchao Deng 2015-08-17 20:52:07 +0000 420) state =
State.RUNNING;
91f579e4 src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java
(Hongchao Deng 2015-08-17 20:52:07 +0000 421) notifyAll();
097b7979 zookeeper/java/src/com/yahoo/zookeeper/server/ZooKeeperServer.java
(Benjamin Reed 2008-05-12 23:01:25 +0000 422) }
{noformat}
{noformat}
commit 91f579e40755de870ed9123c8fd55925517d9aa6
Author: Hongchao Deng <hd...@apache.org>
Date: Mon Aug 17 20:52:07 2015 +0000
ZOOKEEPER-1907 Improve Thread handling (Rakesh R via hdeng)
git-svn-id:
https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1696337
13f79535-47bb-0310-9956-ffa450edef68
{noformat}
[~rakesh_r] could you have a look, please?
CC [~rgs] [~phunt]
> Startup race in ZooKeeperServer
> -------------------------------
>
> Key: ZOOKEEPER-2383
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2383
> Project: ZooKeeper
> Issue Type: Bug
> Components: jmx, server
> Affects Versions: 3.4.8
> Reporter: Steve Rowe
> Attachments: TestZkStandaloneJMXRegistrationRaceConcurrent.java,
> release-3.4.8-extra-logging.patch, zk-3.4.8-MBeanRegistry.log,
> zk-3.4.8-NPE.log
>
>
> In attempting to upgrade Solr's ZooKeeper dependency from 3.4.6 to 3.4.8
> (SOLR-8724) I ran into test failures where attempts to create a node in a
> newly started standalone ZooKeeperServer were failing because of an assertion
> in MBeanRegistry.
> ZooKeeperServer.startup() first sets up its request processor chain then
> registers itself in JMX, but if a connection comes in before the server's JMX
> registration happens, registration of the connection will fail because it
> trips the assertion that (effectively) its parent (the server) has already
> registered itself.
> {code:java|title=ZooKeeperServer.java}
> public synchronized void startup() {
> if (sessionTracker == null) {
> createSessionTracker();
> }
> startSessionTracker();
> setupRequestProcessors();
> registerJMX();
> state = State.RUNNING;
> notifyAll();
> }
> {code}
> {code:java|title=MBeanRegistry.java}
> public void register(ZKMBeanInfo bean, ZKMBeanInfo parent)
> throws JMException
> {
> assert bean != null;
> String path = null;
> if (parent != null) {
> path = mapBean2Path.get(parent);
> assert path != null;
> }
> {code}
> This problem appears to be new with ZK 3.4.8 - AFAIK Solr never had this
> issue with ZK 3.4.6.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
