[
https://issues.apache.org/jira/browse/ZOOKEEPER-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adam Milne-Smith updated ZOOKEEPER-2141:
----------------------------------------
Attachment: ZOOKEEPER-2141.patch
Patrick,
The remaining findbugs complaint was the lack of synchronisation around
"that.aclIndex" in the equals(). The equals is only used by the tests and if
passing the findbugs were not a requirement I probably wouldn't have been too
worried about it - I'm not generally fond of an equals including mutable
fields. I've added the synchronized(that) block in for now. Please do let me
know if you don't think this is appropriate and would prefer something else
like moving the equals logic to the test class only.
I ran test-core-java again locally and
ReconfigRecoveryTest.testCurrentObserverIsParticipantInNewConfig passed. Given
the tests in ReconfigRecoveryTest seem a little intermittent on the trunk right
now (https://builds.apache.org/job/ZooKeeper-trunk-jdk8/521/) I don't think
this was related to my change.
Do let me know if you have any feedback on the code and I'll have a crack at
any changes that you'd like to see.
Thanks,
Adam
> ACL cache in DataTree never removes entries
> -------------------------------------------
>
> Key: ZOOKEEPER-2141
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2141
> Project: ZooKeeper
> Issue Type: Bug
> Affects Versions: 3.4.6
> Reporter: Karol Dudzinski
> Assignee: Adam Milne-Smith
> Attachments: ZOOKEEPER-2141.patch, ZOOKEEPER-2141.patch,
> ZOOKEEPER-2141.patch, ZOOKEEPER-2141.patch, ZOOKEEPER-2141.patch
>
>
> The problem and potential solutions are discussed in
> http://mail-archives.apache.org/mod_mbox/zookeeper-user/201502.mbox/browser
> I will attach a proposed patch in due course.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
