[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15202321#comment-15202321
 ] 

Chris Nauroth commented on ZOOKEEPER-2393:
------------------------------------------

[~arshad.mohammad], thank you for putting this patch together quickly.  Thank 
you also for updating the license information.  I tested this successfully by 
building a distro tarball.  I verified that both server and client produce logs 
as expected out of the box, without additional deployment steps for an SLF4J 
binding.

In zookeeperAdmin.xml, we have 3 remaining references to 1.2.16 in some sample 
classpath settings.  Could you please update those to 1.2.17?

> Revert run-time dependency on log4j and slf4j-log4j12
> -----------------------------------------------------
>
>                 Key: ZOOKEEPER-2393
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2393
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>            Reporter: Arshad Mohammad
>            Assignee: Arshad Mohammad
>             Fix For: 3.5.2, 3.6.0
>
>         Attachments: ZOOKEEPER-2393.patch
>
>
> Zookeeper run-time dependency on log4j and slf4j-log4j12 was removed as part 
> of ZOOKEEPER-1371 jira work.
> Following things were done as part of ZOOKEEPER-1371
> # Removed direct log4j API use from the code, instead used slf4j-api
> # Changed  log4j  and slf4j-log4j12 run time dependency to test time 
> dependency
> # Upgraded log4j, slf4j-log4j12  and slf4j-api versions.
> Here is the component wise version change
> #* (zookeeper)ivy.xml
> log4j: 1.2.15 -->1.7.5
> #* src\contrib\loggraph\ivy.xml
> slf4j-api: 1.6.1 -->1.7.5
> slf4j-log4j12:  1.6.1 -->1.7.5
> log4j: 1.2.15 -->1.7.5
> #* src\contrib\rest\ivy.xml
> slf4j-api: 1.6.1 -->1.7.5
> slf4j-log4j12:  1.6.1 -->1.7.5
> log4j: 1.2.15 -->1.7.5
> #* src\contrib\zooinspector\ivy.xml
> slf4j-api: 1.6.1 -->1.7.5
> slf4j-log4j12:  1.6.1 -->1.7.5
> log4j: 1.2.15 -->1.7.5
> The major problem with ZOOKEEPER-1371 change is that it removed run time 
> dependency. For more detail refer ZOOKEEPER-2342 discussion
> Now as part of this jira revert back only run time dependency, #2, on log4j 
> and slf4j-log4j12.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to