[
https://issues.apache.org/jira/browse/ZOOKEEPER-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15249280#comment-15249280
]
Arshad Mohammad commented on ZOOKEEPER-2139:
--------------------------------------------
# Fixed
# yes default should be {{ENABLE_CLIENT_SASL_DEFAULT}}. changed it
can not use {{ZKClientConfig.isSaslClientEnabled()}} inside {{isEnabled()}} as
it is not static method. {{isEnabled()}} is no more used anywhere in the code.
It is depreciated and will be removed in the next release. So leaving it as it
is.
# Fixed
# Fixed
# Fixed
# Fixed, added timeout test class level
# Fixed
## This jira is removing all the ZooKeeper system properties from client side
code. If any ZooKeeper system property is still there it should be corrected it
this jira itself
## yes, server side code still using system properties, that we can handle in
separate jira
## Corrected {{System.getProperty(ZKClientConfig.LOGIN_CONTEXT_NAME_KEY,
"Client")}} occurence, also corrected its logical problem
### Login.java is the common code between client and server so here it is
wrong to suggest to check only client configuration. Corrected it
> Support multiple ZooKeeper client, with different configurations, in a single
> JVM
> ---------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-2139
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2139
> Project: ZooKeeper
> Issue Type: Improvement
> Components: java client
> Affects Versions: 3.5.0
> Reporter: Surendra Singh Lilhore
> Assignee: Arshad Mohammad
> Priority: Blocker
> Fix For: 3.5.2, 3.6.0
>
> Attachments: ZOOKEEPER-2139-05.patch, ZOOKEEPER-2139-06.patch,
> ZOOKEEPER-2139-07.patch, ZOOKEEPER-2139-08.patch, ZOOKEEPER-2139-09.patch,
> ZOOKEEPER-2139-10.patch, ZOOKEEPER-2139-11.patch, ZOOKEEPER-2139.patch,
> ZOOKEEPER-2139.patch, ZOOKEEPER-2139_1.patch, ZOOKEEPER-2139_2.patch
>
>
> I have two ZK client in one JVM, one is secure client and second is normal
> client (For non secure cluster).
> "zookeeper.sasl.client" system property is "true" by default, because of this
> my second client connection is failing.
> We should pass all client configurations in client constructor like HDFS
> client.
> For example :
> {code}
> public ZooKeeper(String connectString, int sessionTimeout, Watcher watcher,
> Configuration conf) throws IOException
> {
> ......
> ......
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
