----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47354/#review133212 -----------------------------------------------------------
src/java/main/org/apache/zookeeper/common/PathUtils.java (line 111) <https://reviews.apache.org/r/47354/#comment197499> I'm pretty suspect of this method. I'd like to see it removed or at least moved to the test directory (afaict it's just used in tests). My recommendation however would be to remove it entirely. Can't we sue java.io.File here? src/java/main/org/apache/zookeeper/server/ZooKeeperThread.java (line 40) <https://reviews.apache.org/r/47354/#comment197502> this seems like a bad idea to add. Why isn't the caller just providing (minimum) a thread name? That constructor already exists. And having threads named makes debugging so much easier. src/java/main/org/apache/zookeeper/server/quorum/Learner.java <https://reviews.apache.org/r/47354/#comment197508> Why is this patch reverting ZOOKEEPER-1506 ? From what I can tell Flavio committed 1506 on 9/23/15 however this patch seems to revert it? Or perhaps this patch is not against the most recent version of 3.4 branch? Rakesh - can you check the recent commits to 3.4 branch and ensure that this patch isn't reverting them? I suspect something went awry or was missed while updating this patch along the way. - Patrick Hunt On May 13, 2016, 7:22 p.m., Rakesh R wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47354/ > ----------------------------------------------------------- > > (Updated May 13, 2016, 7:22 p.m.) > > > Review request for zookeeper, fpj, Ivan Kelly, Patrick Hunt, and Raul > Gutierrez Segales. > > > Bugs: ZOOKEEPER-1045 > https://issues.apache.org/jira/browse/ZOOKEEPER-1045 > > > Repository: zookeeper-git > > > Description > ------- > > Quorum mutual authentication using SASL mechanism - Digest/Kerberos > > > Diffs > ----- > > ivy.xml 95b0e5a > src/java/main/org/apache/zookeeper/Login.java a214c9c > src/java/main/org/apache/zookeeper/client/ZooKeeperSaslClient.java 21ef0fa > src/java/main/org/apache/zookeeper/common/PathUtils.java 12a6814 > src/java/main/org/apache/zookeeper/server/ZooKeeperSaslServer.java 71870ce > src/java/main/org/apache/zookeeper/server/ZooKeeperThread.java 2830624 > > src/java/main/org/apache/zookeeper/server/auth/SaslServerCallbackHandler.java > 2fbd6ed > src/java/main/org/apache/zookeeper/server/quorum/Leader.java 40c6748 > src/java/main/org/apache/zookeeper/server/quorum/Learner.java c73a8ee > src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java > 8a748c7 > src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java > 20e5f16 > src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 2f0f21b > src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java > 8ae820d > src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java > e9c8007 > > src/java/main/org/apache/zookeeper/server/quorum/auth/NullQuorumAuthClient.java > PRE-CREATION > > src/java/main/org/apache/zookeeper/server/quorum/auth/NullQuorumAuthServer.java > PRE-CREATION > src/java/main/org/apache/zookeeper/server/quorum/auth/QuorumAuth.java > PRE-CREATION > src/java/main/org/apache/zookeeper/server/quorum/auth/QuorumAuthClient.java > PRE-CREATION > src/java/main/org/apache/zookeeper/server/quorum/auth/QuorumAuthServer.java > PRE-CREATION > src/java/main/org/apache/zookeeper/server/quorum/auth/README.md > PRE-CREATION > > src/java/main/org/apache/zookeeper/server/quorum/auth/SaslQuorumAuthClient.java > PRE-CREATION > > src/java/main/org/apache/zookeeper/server/quorum/auth/SaslQuorumAuthServer.java > PRE-CREATION > src/java/main/org/apache/zookeeper/util/SecurityUtils.java PRE-CREATION > src/java/systest/org/apache/zookeeper/test/system/BaseSysTest.java 3d963d2 > src/java/systest/org/apache/zookeeper/test/system/QuorumPeerInstance.java > 95aebc8 > src/java/test/data/kerberos/minikdc-krb5.conf PRE-CREATION > src/java/test/data/kerberos/minikdc.ldiff PRE-CREATION > src/java/test/org/apache/zookeeper/server/quorum/CnxManagerTest.java > 831d3ed > > src/java/test/org/apache/zookeeper/server/quorum/FLEBackwardElectionRoundTest.java > c1259d1 > src/java/test/org/apache/zookeeper/server/quorum/FLECompatibilityTest.java > 72e4fc9 > src/java/test/org/apache/zookeeper/server/quorum/FLEDontCareTest.java > a4c0cb0 > src/java/test/org/apache/zookeeper/server/quorum/FLELostMessageTest.java > 39a53ca > src/java/test/org/apache/zookeeper/server/quorum/LearnerTest.java 2ae57ce > src/java/test/org/apache/zookeeper/server/quorum/QuorumCnxManagerTest.java > PRE-CREATION > src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java > ef552db > src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java ab8ce42 > > src/java/test/org/apache/zookeeper/server/quorum/auth/KerberosSecurityTestcase.java > PRE-CREATION > > src/java/test/org/apache/zookeeper/server/quorum/auth/KerberosTestUtils.java > PRE-CREATION > src/java/test/org/apache/zookeeper/server/quorum/auth/MiniKdc.java > PRE-CREATION > src/java/test/org/apache/zookeeper/server/quorum/auth/MiniKdcTest.java > PRE-CREATION > > src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumAuthTestBase.java > PRE-CREATION > > src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumAuthUpgradeTest.java > PRE-CREATION > > src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumDigestAuthTest.java > PRE-CREATION > > src/java/test/org/apache/zookeeper/server/quorum/auth/QuorumKerberosAuthTest.java > PRE-CREATION > src/java/test/org/apache/zookeeper/test/FLENewEpochTest.java 1731e6e > src/java/test/org/apache/zookeeper/test/FLEPredicateTest.java 8088505 > src/java/test/org/apache/zookeeper/test/FLERestartTest.java a7cecf6 > src/java/test/org/apache/zookeeper/test/FLETest.java 6281a57 > src/java/test/org/apache/zookeeper/test/FLEZeroWeightTest.java e8a8cf7 > src/java/test/org/apache/zookeeper/test/HierarchicalQuorumTest.java c6573f4 > src/java/test/org/apache/zookeeper/test/LENonTerminateTest.java de26698 > src/java/test/org/apache/zookeeper/test/LETest.java 0fd3430 > src/java/test/org/apache/zookeeper/test/QuorumBase.java 49cff35 > src/java/test/org/apache/zookeeper/test/QuorumUtil.java 1f2dbbc > src/java/test/org/apache/zookeeper/test/TruncateTest.java 66ff63d > src/zookeeper.jute 6521e54 > > Diff: https://reviews.apache.org/r/47354/diff/ > > > Testing > ------- > > Added unit test cases to verify the changes. > > > Thanks, > > Rakesh R > >
