[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15287445#comment-15287445
 ] 

Michael Han commented on ZOOKEEPER-1045:
----------------------------------------

Hi [~rakeshr], two suggestions:
1. It looks like the https://reviews.apache.org/r/47354 is based on {noformat} 
https://github.com/apache/zookeeper/pull/49/files {noformat}, which is 
different comparing to the patch attached to the JIRA. Do you mind to update 
the patch attached as well, if the current patch attached is out dated?

2. The patch is targeting branch 3.4, so it might be better to rename the patch 
attached to the JIRA with branch name to reflect this.


> Quorum Peer mutual authentication
> ---------------------------------
>
>                 Key: ZOOKEEPER-1045
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1045
>             Project: ZooKeeper
>          Issue Type: New Feature
>          Components: server
>            Reporter: Eugene Koontz
>            Assignee: Rakesh R
>            Priority: Critical
>         Attachments: ZOOKEEPER-1045-00.patch, ZOOKEEPER-1045-Rolling Upgrade 
> Design Proposal.pdf
>
>
> ZOOKEEPER-938 addresses mutual authentication between clients and servers. 
> This bug, on the other hand, is for authentication among quorum peers. 
> Hopefully much of the work done on SASL integration with Zookeeper for 
> ZOOKEEPER-938 can be used as a foundation for this enhancement.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to